From e4ca58a0423c153b84c1f84f204fbd93da7b823d Mon Sep 17 00:00:00 2001
From: Maxime Bajeux <max.bajeux@gmail.com>
Date: Fri, 7 Aug 2020 00:55:36 +0200
Subject: [PATCH] fix(application): hpa breaks application edit (#4166)

---
 app/kubernetes/services/applicationService.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/kubernetes/services/applicationService.js b/app/kubernetes/services/applicationService.js
index a6bfdd2f7..e3c549de8 100644
--- a/app/kubernetes/services/applicationService.js
+++ b/app/kubernetes/services/applicationService.js
@@ -276,8 +276,10 @@ class KubernetesApplicationService {
 
       const newKind = KubernetesHorizontalPodAutoScalerHelper.getApplicationTypeString(newApp);
       const newAutoScaler = KubernetesHorizontalPodAutoScalerConverter.applicationFormValuesToModel(newFormValues, newKind);
-      if (_.isEmpty(oldFormValues.AutoScaler)) {
-        await this.KubernetesHorizontalPodAutoScalerService.create(newAutoScaler);
+      if (!oldFormValues.AutoScaler.IsUsed) {
+        if (newFormValues.AutoScaler.IsUsed) {
+          await this.KubernetesHorizontalPodAutoScalerService.create(newAutoScaler);
+        }
       } else {
         const oldKind = KubernetesHorizontalPodAutoScalerHelper.getApplicationTypeString(oldApp);
         const oldAutoScaler = KubernetesHorizontalPodAutoScalerConverter.applicationFormValuesToModel(oldFormValues, oldKind);