From f656ad71240f1ef5ef46420f48121eb7d62c668c Mon Sep 17 00:00:00 2001 From: cong meng Date: Mon, 14 Dec 2020 12:25:00 +1300 Subject: [PATCH] fix(frontend): fix incorrect datatable selection count on text filter change (#4474) Co-authored-by: Simon Meng --- .../components/datatables/genericDatatableController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/portainer/components/datatables/genericDatatableController.js b/app/portainer/components/datatables/genericDatatableController.js index a98a66fbf..8567dcb87 100644 --- a/app/portainer/components/datatables/genericDatatableController.js +++ b/app/portainer/components/datatables/genericDatatableController.js @@ -70,7 +70,7 @@ angular.module('portainer.app').controller('GenericDatatableController', [ item.Checked = !item.Checked; this.state.firstClickedItem = item; } - this.state.selectedItems = this.dataset.filter((i) => i.Checked); + this.state.selectedItems = _.uniq(_.concat(this.state.selectedItems, this.state.filteredDataSet)).filter((i) => i.Checked); if (event && this.state.selectAll && this.state.selectedItems.length !== this.state.filteredDataSet.length) { this.state.selectAll = false; }