Docker/portainer
Docker/portainer
1
0
Fork 0
mirror of https://github.com/portainer/portainer.git synced 2025-07-23 23:39:41 +02:00
Code Issues Releases Activity

fix(app): parse nan in validation check [EE-6714] (#11246)

Browse source
This commit is contained in:
Ali 2024-02-26 09:20:54 +13:00 • committed by GitHub
parent 3caf1ddb7d
commit f6beedf0d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/react/kubernetes/applications/components/ResourceReservationFormSection/resourceReservationValidation.ts
View file

@ -99,6 +99,8 @@ function hasSuitableNode(
cpuLimit: number, cpuLimit: number,
nodeLimits: NodesLimits nodeLimits: NodesLimits
) { ) {
const nanParsedMemoryLimit = Number.isNaN(memoryLimit) ? 0 : memoryLimit;
const nanParsedCPULimit = Number.isNaN(cpuLimit) ? 0 : cpuLimit;
// transform the nodelimits from bytes to MB // transform the nodelimits from bytes to MB
const limits = Object.values(nodeLimits).map((nodeLimit) => ({ const limits = Object.values(nodeLimits).map((nodeLimit) => ({
...nodeLimit, ...nodeLimit,
@ -108,6 +110,8 @@ function hasSuitableNode(
})); }));
// make sure there's a node available with enough memory and cpu // make sure there's a node available with enough memory and cpu
return limits.some( return limits.some(
(nodeLimit) => nodeLimit.Memory >= memoryLimit && nodeLimit.CPU >= cpuLimit (nodeLimit) =>
nodeLimit.Memory >= nanParsedMemoryLimit &&
nodeLimit.CPU >= nanParsedCPULimit
); );
} }