mirror of
https://github.com/portainer/portainer.git
synced 2025-07-23 07:19:41 +02:00
69c17986d9
* feat(access-token): Multi-auth middleware support EE-1891 (#5936) * AnyAuth middleware initial implementation with tests * using mux.MiddlewareFunc instead of custom definition * removed redundant comments * - ExtractBearerToken bouncer func made private - changed helm token handling functionality to use jwt service to convert token to jwt string - updated tests - fixed helm list broken test due to missing token in request context * rename mwCheckAuthentication -> mwCheckJWTAuthentication * - introduce initial api-key auth support using X-API-KEY header - added tests to validate x-api-key request header presence * updated core mwAuthenticatedUser middleware to support multiple auth paradigms * - simplified anyAuth middleware - enforcing authmiddleware to implement verificationFunc interface - created tests for middleware * simplify bouncer Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com> * feat(api-key): user-access-token generation endpoint EE-1889 EE-1888 EE-1895 (#6012) * user-access-token generation endpoint * fix comment * - introduction of apikey service - seperation of repository from service logic - called in handler * fixed tests * - fixed api key prefix - added tests * added another test for digest matching * updated swagger spec for access token creation * api key response returns raw key and struct - easing testability * test for api key prefix length * added another TODO to middleware * - api-key prefix rune -> string (rune does not auto-encode when response sent back to client) - digest -> pointer as we want to allow nil values and omit digest in responses (when nil) * - updated apikey struct - updated apikey service to support all common operations - updated apikey repo - integration of apikey service into bouncer - added test for all apikey service functions - boilerplate code for apikey service integration * - user access token generation tests - apiKeyLookup updated to support query params - added api-key tests for query params - added api-key tests for apiKeyLookup * get and remove access token handlers * get and remove access token handler tests * - delete user deletes all associated api keys - tests for this functionality * removed redundant []byte cast * automatic api-key eviction set within cache for 1 hour * fixed bug with loop var using final value * fixed service comment * ignore bolt error responses * case-insensitive query param check * simplified query var assignment * - added GetAPIKey func to get by unique id - updated DeleteAPIKey func to not require user ID - updated tests * GenerateRandomKey helper func from github.com/gorilla/securecookie moved to codebase * json response casing for api-keys fixed * updating api-key will update the cache * updated golang LRU cache * using hashicorps golang-LRU cache for api keys * simplified jwt check in create user access token * fixed api-key update logic on cache miss * Prefix generated api-keys with `ptr_` (#6067) * prefix api-keys with 'ptr_' * updated apikey description * refactor Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com> * helm list test refactor * fixed user delete test * reduce test nil pointer errors * using correct http 201 created status code for token creation; updated tests * fixed swagger doc user id path param for user access token based endpoints * added api-key security openapi spec to existing jwt secured endpoints (#6091) * fixed flaky test * apikey datecreated and lastused attrs converted to unix timestamp * feat(user): added access token datatable. (#6124) * feat(user): added access token datatable. * feat(tokens): only display lastUsed time when it is not the default date * Update app/portainer/views/account/accountController.js Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * Update app/portainer/views/account/accountController.js Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * Update app/portainer/views/account/accountController.js Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * Update app/portainer/components/datatables/access-tokens-datatable/accessTokensDatatableController.js Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * Update app/portainer/services/api/userService.js Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * feat(improvements): proposed datatable improvements to speed up dev time (#6138) * modal code update * updated datatable filenames, updated controller to be default class export * fix(access-token): code improvement. Co-authored-by: zees-dev <63374656+zees-dev@users.noreply.github.com> * feat(apikeys): create access token view initial implementation EE-1886 (#6129) * CopyButton implementation * Code component implementation * ToolTip component migration to another folder * TextTip component implementation - continued * form Heading component * Button component updated to be more dynamic * copybutton - small size * form control pass tip error * texttip small text * CreateAccessToken react feature initial implementation * create user access token angularjs view implementation * registration of CreateAccessToken component in AngularJS * user token generation API request moved to angular service, method passed down instead * consistent naming of access token operations; clustered similar code together * any user can add access token * create access token page routing * moved code component to the correct location * removed isadmin check as all functionality applicable to all users * create access token angular view moved up a level * fixed PR issues, updated PR * addressed PR issues/improvements * explicit hr for horizontal line * fixed merge conflict storybook build breaking * - apikey test - cache test * addressed testing issues: - description validations - remove token description link on table * fix(api-keys): user role change evicts user keys in cache EE-2113 (#6168) * user role change evicts user api keys in cache * EvictUserKeyCache -> InvalidateUserKeyCache * godoc for InvalidateUserKeyCache func * additional test line * disable add access token button after adding token to prevent spam Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com> Co-authored-by: fhanportainer <79428273+fhanportainer@users.noreply.github.com>
289 lines
7.6 KiB
Go
289 lines
7.6 KiB
Go
package apikey
|
|
|
|
import (
|
|
"crypto/sha256"
|
|
"log"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
portainer "github.com/portainer/portainer/api"
|
|
"github.com/portainer/portainer/api/bolt"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_SatisfiesAPIKeyServiceInterface(t *testing.T) {
|
|
is := assert.New(t)
|
|
is.Implements((*APIKeyService)(nil), NewAPIKeyService(nil, nil))
|
|
}
|
|
|
|
func Test_GenerateApiKey(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully generates API key", func(t *testing.T) {
|
|
desc := "test-1"
|
|
rawKey, apiKey, err := service.GenerateApiKey(portainer.User{ID: 1}, desc)
|
|
is.NoError(err)
|
|
is.NotEmpty(rawKey)
|
|
is.NotEmpty(apiKey)
|
|
is.Equal(desc, apiKey.Description)
|
|
})
|
|
|
|
t.Run("Api key prefix is 7 chars", func(t *testing.T) {
|
|
rawKey, apiKey, err := service.GenerateApiKey(portainer.User{ID: 1}, "test-2")
|
|
is.NoError(err)
|
|
|
|
is.Equal(rawKey[:7], apiKey.Prefix)
|
|
is.Len(apiKey.Prefix, 7)
|
|
})
|
|
|
|
t.Run("Api key has 'ptr_' as prefix", func(t *testing.T) {
|
|
rawKey, _, err := service.GenerateApiKey(portainer.User{ID: 1}, "test-x")
|
|
is.NoError(err)
|
|
|
|
is.Equal(portainerAPIKeyPrefix, "ptr_")
|
|
is.True(strings.HasPrefix(rawKey, "ptr_"))
|
|
})
|
|
|
|
t.Run("Successfully caches API key", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-3")
|
|
is.NoError(err)
|
|
|
|
userFromCache, apiKeyFromCache, ok := service.cache.Get(apiKey.Digest)
|
|
is.True(ok)
|
|
is.Equal(user, userFromCache)
|
|
is.Equal(apiKey, &apiKeyFromCache)
|
|
})
|
|
|
|
t.Run("Decoded raw api-key digest matches generated digest", func(t *testing.T) {
|
|
rawKey, apiKey, err := service.GenerateApiKey(portainer.User{ID: 1}, "test-4")
|
|
is.NoError(err)
|
|
|
|
generatedDigest := sha256.Sum256([]byte(rawKey))
|
|
|
|
is.Equal(apiKey.Digest, generatedDigest[:])
|
|
})
|
|
}
|
|
|
|
func Test_GetAPIKeys(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully returns all API keys", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, _, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
_, _, err = service.GenerateApiKey(user, "test-2")
|
|
is.NoError(err)
|
|
|
|
keys, err := service.GetAPIKeys(user.ID)
|
|
is.NoError(err)
|
|
is.Len(keys, 2)
|
|
})
|
|
}
|
|
|
|
func Test_GetDigestUserAndKey(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully returns user and api key associated to digest", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
|
|
userGot, apiKeyGot, err := service.GetDigestUserAndKey(apiKey.Digest)
|
|
is.NoError(err)
|
|
is.Equal(user, userGot)
|
|
is.Equal(*apiKey, apiKeyGot)
|
|
})
|
|
|
|
t.Run("Successfully caches user and api key associated to digest", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
|
|
userGot, apiKeyGot, err := service.GetDigestUserAndKey(apiKey.Digest)
|
|
is.NoError(err)
|
|
is.Equal(user, userGot)
|
|
is.Equal(*apiKey, apiKeyGot)
|
|
|
|
userFromCache, apiKeyFromCache, ok := service.cache.Get(apiKey.Digest)
|
|
is.True(ok)
|
|
is.Equal(userGot, userFromCache)
|
|
is.Equal(apiKeyGot, apiKeyFromCache)
|
|
})
|
|
}
|
|
|
|
func Test_UpdateAPIKey(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully updates the api-key LastUsed time", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
store.User().CreateUser(&user)
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-x")
|
|
is.NoError(err)
|
|
|
|
apiKey.LastUsed = time.Now().UTC().Unix()
|
|
err = service.UpdateAPIKey(apiKey)
|
|
is.NoError(err)
|
|
|
|
_, apiKeyGot, err := service.GetDigestUserAndKey(apiKey.Digest)
|
|
is.NoError(err)
|
|
|
|
log.Println(apiKey)
|
|
log.Println(apiKeyGot)
|
|
|
|
is.Equal(apiKey.LastUsed, apiKeyGot.LastUsed)
|
|
|
|
})
|
|
|
|
t.Run("Successfully updates api-key in cache upon api-key update", func(t *testing.T) {
|
|
_, apiKey, err := service.GenerateApiKey(portainer.User{ID: 1}, "test-x2")
|
|
is.NoError(err)
|
|
|
|
_, apiKeyFromCache, ok := service.cache.Get(apiKey.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey, apiKeyFromCache)
|
|
|
|
apiKey.LastUsed = time.Now().UTC().Unix()
|
|
is.NotEqual(*apiKey, apiKeyFromCache)
|
|
|
|
err = service.UpdateAPIKey(apiKey)
|
|
is.NoError(err)
|
|
|
|
_, updatedAPIKeyFromCache, ok := service.cache.Get(apiKey.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey, updatedAPIKeyFromCache)
|
|
})
|
|
}
|
|
|
|
func Test_DeleteAPIKey(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully updates the api-key", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
|
|
_, apiKeyGot, err := service.GetDigestUserAndKey(apiKey.Digest)
|
|
is.NoError(err)
|
|
is.Equal(*apiKey, apiKeyGot)
|
|
|
|
err = service.DeleteAPIKey(apiKey.ID)
|
|
is.NoError(err)
|
|
|
|
_, _, err = service.GetDigestUserAndKey(apiKey.Digest)
|
|
is.Error(err)
|
|
})
|
|
|
|
t.Run("Successfully removes api-key from cache upon deletion", func(t *testing.T) {
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
|
|
_, apiKeyFromCache, ok := service.cache.Get(apiKey.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey, apiKeyFromCache)
|
|
|
|
err = service.DeleteAPIKey(apiKey.ID)
|
|
is.NoError(err)
|
|
|
|
_, _, ok = service.cache.Get(apiKey.Digest)
|
|
is.False(ok)
|
|
})
|
|
}
|
|
|
|
func Test_InvalidateUserKeyCache(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
store, teardown := bolt.MustNewTestStore(true)
|
|
defer teardown()
|
|
|
|
service := NewAPIKeyService(store.APIKeyRepository(), store.User())
|
|
|
|
t.Run("Successfully updates evicts keys from cache", func(t *testing.T) {
|
|
// generate api keys
|
|
user := portainer.User{ID: 1}
|
|
_, apiKey1, err := service.GenerateApiKey(user, "test-1")
|
|
is.NoError(err)
|
|
|
|
_, apiKey2, err := service.GenerateApiKey(user, "test-2")
|
|
is.NoError(err)
|
|
|
|
// verify api keys are present in cache
|
|
_, apiKeyFromCache, ok := service.cache.Get(apiKey1.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey1, apiKeyFromCache)
|
|
|
|
_, apiKeyFromCache, ok = service.cache.Get(apiKey2.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey2, apiKeyFromCache)
|
|
|
|
// evict cache
|
|
ok = service.InvalidateUserKeyCache(user.ID)
|
|
is.True(ok)
|
|
|
|
// verify users keys have been flushed from cache
|
|
_, _, ok = service.cache.Get(apiKey1.Digest)
|
|
is.False(ok)
|
|
|
|
_, _, ok = service.cache.Get(apiKey2.Digest)
|
|
is.False(ok)
|
|
})
|
|
|
|
t.Run("User key eviction does not affect other users keys", func(t *testing.T) {
|
|
// generate keys for 2 users
|
|
user1 := portainer.User{ID: 1}
|
|
_, apiKey1, err := service.GenerateApiKey(user1, "test-1")
|
|
is.NoError(err)
|
|
|
|
user2 := portainer.User{ID: 2}
|
|
_, apiKey2, err := service.GenerateApiKey(user2, "test-2")
|
|
is.NoError(err)
|
|
|
|
// verify keys in cache
|
|
_, apiKeyFromCache, ok := service.cache.Get(apiKey1.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey1, apiKeyFromCache)
|
|
|
|
_, apiKeyFromCache, ok = service.cache.Get(apiKey2.Digest)
|
|
is.True(ok)
|
|
is.Equal(*apiKey2, apiKeyFromCache)
|
|
|
|
// evict key of single user from cache
|
|
ok = service.cache.InvalidateUserKeyCache(user1.ID)
|
|
is.True(ok)
|
|
|
|
// verify user1 key has been flushed from cache
|
|
_, _, ok = service.cache.Get(apiKey1.Digest)
|
|
is.False(ok)
|
|
|
|
// verify user2 key is still in cache
|
|
_, _, ok = service.cache.Get(apiKey2.Digest)
|
|
is.True(ok)
|
|
})
|
|
}
|