mirror of
https://github.com/portainer/portainer.git
synced 2025-07-20 13:59:40 +02:00
* feat(api): decorate Docker resource creation response with resource control * fix(api): fix a potential resource control conflict between stacks/volumes * feat(api): generate a default private resource control instead of admin only * fix(api): fix default RC value * fix(api): update RC authorizations check to support admin only flag * refactor(api): relocate access control related methods * fix(api): fix a potential conflict when fetching RC from database * refactor(api): refactor access control logic * refactor(api): remove the concept of DecoratedStack * feat(api): automatically remove RC when removing a Docker resource * refactor(api): update filter resource methods documentation * refactor(api): update proxy package structure * refactor(api): renamed proxy/misc package * feat(api): re-introduce ResourceControlDelete operation as admin restricted * refactor(api): relocate default endpoint authorizations * feat(api): migrate RBAC data * feat(app): ResourceControl management refactor * fix(api): fix access control issue on stack deletion and automatically delete RC * fix(api): fix stack filtering * fix(api): fix UpdateResourceControl operation checks * refactor(api): introduce a NewTransport builder method * refactor(api): inject endpoint in Docker transport * refactor(api): introduce Docker client into Docker transport * refactor(api): refactor http/proxy package * feat(api): inspect a Docker resource labels during access control validation * fix(api): only apply automatic resource control creation on success response * fix(api): fix stack access control check * fix(api): use StatusCreated instead of StatusOK for automatic resource control creation * fix(app): resource control fixes * fix(api): fix an issue preventing administrator to inspect a resource with a RC * refactor(api): remove useless error return * refactor(api): document DecorateStacks function * fix(api): fix invalid resource control type for container deletion * feat(api): support Docker system networks * feat(api): update Swagger docs * refactor(api): rename transport variable * refactor(api): rename transport variable * feat(networks): add system tag for system networks * feat(api): add support for resource control labels * feat(api): upgrade to DBVersion 22 * refactor(api): refactor access control management in Docker proxy * refactor(api): re-implement docker proxy taskListOperation * refactor(api): review parameters declaration * refactor(api): remove extra blank line * refactor(api): review method comments * fix(api): fix invalid ServerAddress property and review method visibility * feat(api): update error message * feat(api): update restrictedVolumeBrowserOperation method * refactor(api): refactor method parameters * refactor(api): minor refactor * refactor(api): change Azure transport visibility * refactor(api): update struct documentation * refactor(api): update struct documentation * feat(api): review restrictedResourceOperation method * refactor(api): remove unused authorization methods * feat(api): apply RBAC when enabled on stack operations * fix(api): fix invalid data migration procedure for DBVersion = 22 * fix(app): RC duplicate on private resource * feat(api): change Docker API version logic for libcompose/client factory * fix(api): update access denied error message to be Docker API compliant * fix(api): update volume browsing authorizations data migration * fix(api): fix an issue with access control in multi-node agent Swarm cluster
145 lines
5.3 KiB
Go
145 lines
5.3 KiB
Go
package stacks
|
|
|
|
import (
|
|
"errors"
|
|
"log"
|
|
"net/http"
|
|
|
|
"github.com/docker/cli/cli/compose/loader"
|
|
"github.com/docker/cli/cli/compose/types"
|
|
httperror "github.com/portainer/libhttp/error"
|
|
"github.com/portainer/libhttp/request"
|
|
"github.com/portainer/libhttp/response"
|
|
"github.com/portainer/portainer/api"
|
|
"github.com/portainer/portainer/api/http/security"
|
|
)
|
|
|
|
func (handler *Handler) cleanUp(stack *portainer.Stack, doCleanUp *bool) error {
|
|
if !*doCleanUp {
|
|
return nil
|
|
}
|
|
|
|
err := handler.FileService.RemoveDirectory(stack.ProjectPath)
|
|
if err != nil {
|
|
log.Printf("http error: Unable to cleanup stack creation (err=%s)\n", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// POST request on /api/stacks?type=<type>&method=<method>&endpointId=<endpointId>
|
|
func (handler *Handler) stackCreate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
|
|
stackType, err := request.RetrieveNumericQueryParameter(r, "type", false)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid query parameter: type", err}
|
|
}
|
|
|
|
method, err := request.RetrieveQueryParameter(r, "method", false)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid query parameter: method", err}
|
|
}
|
|
|
|
endpointID, err := request.RetrieveNumericQueryParameter(r, "endpointId", false)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid query parameter: endpointId", err}
|
|
}
|
|
|
|
endpoint, err := handler.EndpointService.Endpoint(portainer.EndpointID(endpointID))
|
|
if err == portainer.ErrObjectNotFound {
|
|
return &httperror.HandlerError{http.StatusNotFound, "Unable to find an endpoint with the specified identifier inside the database", err}
|
|
} else if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to find an endpoint with the specified identifier inside the database", err}
|
|
}
|
|
|
|
err = handler.requestBouncer.AuthorizedEndpointOperation(r, endpoint, true)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusForbidden, "Permission denied to access endpoint", err}
|
|
}
|
|
|
|
tokenData, err := security.RetrieveTokenData(r)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to retrieve user details from authentication token", err}
|
|
}
|
|
|
|
switch portainer.StackType(stackType) {
|
|
case portainer.DockerSwarmStack:
|
|
return handler.createSwarmStack(w, r, method, endpoint, tokenData.ID)
|
|
case portainer.DockerComposeStack:
|
|
return handler.createComposeStack(w, r, method, endpoint, tokenData.ID)
|
|
}
|
|
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid value for query parameter: type. Value must be one of: 1 (Swarm stack) or 2 (Compose stack)", errors.New(request.ErrInvalidQueryParameter)}
|
|
}
|
|
|
|
func (handler *Handler) createComposeStack(w http.ResponseWriter, r *http.Request, method string, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
|
|
|
|
switch method {
|
|
case "string":
|
|
return handler.createComposeStackFromFileContent(w, r, endpoint, userID)
|
|
case "repository":
|
|
return handler.createComposeStackFromGitRepository(w, r, endpoint, userID)
|
|
case "file":
|
|
return handler.createComposeStackFromFileUpload(w, r, endpoint, userID)
|
|
}
|
|
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid value for query parameter: method. Value must be one of: string, repository or file", errors.New(request.ErrInvalidQueryParameter)}
|
|
}
|
|
|
|
func (handler *Handler) createSwarmStack(w http.ResponseWriter, r *http.Request, method string, endpoint *portainer.Endpoint, userID portainer.UserID) *httperror.HandlerError {
|
|
switch method {
|
|
case "string":
|
|
return handler.createSwarmStackFromFileContent(w, r, endpoint, userID)
|
|
case "repository":
|
|
return handler.createSwarmStackFromGitRepository(w, r, endpoint, userID)
|
|
case "file":
|
|
return handler.createSwarmStackFromFileUpload(w, r, endpoint, userID)
|
|
}
|
|
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid value for query parameter: method. Value must be one of: string, repository or file", errors.New(request.ErrInvalidQueryParameter)}
|
|
}
|
|
|
|
func (handler *Handler) isValidStackFile(stackFileContent []byte) (bool, error) {
|
|
composeConfigYAML, err := loader.ParseYAML(stackFileContent)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
composeConfigFile := types.ConfigFile{
|
|
Config: composeConfigYAML,
|
|
}
|
|
|
|
composeConfigDetails := types.ConfigDetails{
|
|
ConfigFiles: []types.ConfigFile{composeConfigFile},
|
|
Environment: map[string]string{},
|
|
}
|
|
|
|
composeConfig, err := loader.Load(composeConfigDetails, func(options *loader.Options) {
|
|
options.SkipValidation = true
|
|
options.SkipInterpolation = true
|
|
})
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
for key := range composeConfig.Services {
|
|
service := composeConfig.Services[key]
|
|
for _, volume := range service.Volumes {
|
|
if volume.Type == "bind" {
|
|
return false, nil
|
|
}
|
|
}
|
|
}
|
|
|
|
return true, nil
|
|
}
|
|
|
|
func (handler *Handler) decorateStackResponse(w http.ResponseWriter, stack *portainer.Stack, userID portainer.UserID) *httperror.HandlerError {
|
|
resourceControl := portainer.NewPrivateResourceControl(stack.Name, portainer.StackResourceControl, userID)
|
|
|
|
err := handler.ResourceControlService.CreateResourceControl(resourceControl)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to persist resource control inside the database", err}
|
|
}
|
|
|
|
stack.ResourceControl = resourceControl
|
|
return response.JSON(w, stack)
|
|
}
|