mirror of
https://github.com/portainer/portainer.git
synced 2025-07-22 06:49:40 +02:00
* feat(api): decorate Docker resource creation response with resource control * fix(api): fix a potential resource control conflict between stacks/volumes * feat(api): generate a default private resource control instead of admin only * fix(api): fix default RC value * fix(api): update RC authorizations check to support admin only flag * refactor(api): relocate access control related methods * fix(api): fix a potential conflict when fetching RC from database * refactor(api): refactor access control logic * refactor(api): remove the concept of DecoratedStack * feat(api): automatically remove RC when removing a Docker resource * refactor(api): update filter resource methods documentation * refactor(api): update proxy package structure * refactor(api): renamed proxy/misc package * feat(api): re-introduce ResourceControlDelete operation as admin restricted * refactor(api): relocate default endpoint authorizations * feat(api): migrate RBAC data * feat(app): ResourceControl management refactor * fix(api): fix access control issue on stack deletion and automatically delete RC * fix(api): fix stack filtering * fix(api): fix UpdateResourceControl operation checks * refactor(api): introduce a NewTransport builder method * refactor(api): inject endpoint in Docker transport * refactor(api): introduce Docker client into Docker transport * refactor(api): refactor http/proxy package * feat(api): inspect a Docker resource labels during access control validation * fix(api): only apply automatic resource control creation on success response * fix(api): fix stack access control check * fix(api): use StatusCreated instead of StatusOK for automatic resource control creation * fix(app): resource control fixes * fix(api): fix an issue preventing administrator to inspect a resource with a RC * refactor(api): remove useless error return * refactor(api): document DecorateStacks function * fix(api): fix invalid resource control type for container deletion * feat(api): support Docker system networks * feat(api): update Swagger docs * refactor(api): rename transport variable * refactor(api): rename transport variable * feat(networks): add system tag for system networks * feat(api): add support for resource control labels * feat(api): upgrade to DBVersion 22 * refactor(api): refactor access control management in Docker proxy * refactor(api): re-implement docker proxy taskListOperation * refactor(api): review parameters declaration * refactor(api): remove extra blank line * refactor(api): review method comments * fix(api): fix invalid ServerAddress property and review method visibility * feat(api): update error message * feat(api): update restrictedVolumeBrowserOperation method * refactor(api): refactor method parameters * refactor(api): minor refactor * refactor(api): change Azure transport visibility * refactor(api): update struct documentation * refactor(api): update struct documentation * feat(api): review restrictedResourceOperation method * refactor(api): remove unused authorization methods * feat(api): apply RBAC when enabled on stack operations * fix(api): fix invalid data migration procedure for DBVersion = 22 * fix(app): RC duplicate on private resource * feat(api): change Docker API version logic for libcompose/client factory * fix(api): update access denied error message to be Docker API compliant * fix(api): update volume browsing authorizations data migration * fix(api): fix an issue with access control in multi-node agent Swarm cluster
188 lines
6 KiB
Go
188 lines
6 KiB
Go
package endpoints
|
|
|
|
import (
|
|
"net/http"
|
|
"reflect"
|
|
"strconv"
|
|
|
|
httperror "github.com/portainer/libhttp/error"
|
|
"github.com/portainer/libhttp/request"
|
|
"github.com/portainer/libhttp/response"
|
|
"github.com/portainer/portainer/api"
|
|
"github.com/portainer/portainer/api/http/client"
|
|
)
|
|
|
|
type endpointUpdatePayload struct {
|
|
Name *string
|
|
URL *string
|
|
PublicURL *string
|
|
GroupID *int
|
|
TLS *bool
|
|
TLSSkipVerify *bool
|
|
TLSSkipClientVerify *bool
|
|
Status *int
|
|
AzureApplicationID *string
|
|
AzureTenantID *string
|
|
AzureAuthenticationKey *string
|
|
Tags []string
|
|
UserAccessPolicies portainer.UserAccessPolicies
|
|
TeamAccessPolicies portainer.TeamAccessPolicies
|
|
}
|
|
|
|
func (payload *endpointUpdatePayload) Validate(r *http.Request) error {
|
|
return nil
|
|
}
|
|
|
|
// PUT request on /api/endpoints/:id
|
|
func (handler *Handler) endpointUpdate(w http.ResponseWriter, r *http.Request) *httperror.HandlerError {
|
|
if !handler.authorizeEndpointManagement {
|
|
return &httperror.HandlerError{http.StatusServiceUnavailable, "Endpoint management is disabled", ErrEndpointManagementDisabled}
|
|
}
|
|
|
|
endpointID, err := request.RetrieveNumericRouteVariableValue(r, "id")
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid endpoint identifier route variable", err}
|
|
}
|
|
|
|
var payload endpointUpdatePayload
|
|
err = request.DecodeAndValidateJSONPayload(r, &payload)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusBadRequest, "Invalid request payload", err}
|
|
}
|
|
|
|
endpoint, err := handler.EndpointService.Endpoint(portainer.EndpointID(endpointID))
|
|
if err == portainer.ErrObjectNotFound {
|
|
return &httperror.HandlerError{http.StatusNotFound, "Unable to find an endpoint with the specified identifier inside the database", err}
|
|
} else if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to find an endpoint with the specified identifier inside the database", err}
|
|
}
|
|
|
|
if payload.Name != nil {
|
|
endpoint.Name = *payload.Name
|
|
}
|
|
|
|
if payload.URL != nil {
|
|
endpoint.URL = *payload.URL
|
|
}
|
|
|
|
if payload.PublicURL != nil {
|
|
endpoint.PublicURL = *payload.PublicURL
|
|
}
|
|
|
|
if payload.GroupID != nil {
|
|
endpoint.GroupID = portainer.EndpointGroupID(*payload.GroupID)
|
|
}
|
|
|
|
if payload.Tags != nil {
|
|
endpoint.Tags = payload.Tags
|
|
}
|
|
|
|
updateAuthorizations := false
|
|
if payload.UserAccessPolicies != nil && !reflect.DeepEqual(payload.UserAccessPolicies, endpoint.UserAccessPolicies) {
|
|
endpoint.UserAccessPolicies = payload.UserAccessPolicies
|
|
updateAuthorizations = true
|
|
}
|
|
|
|
if payload.TeamAccessPolicies != nil && !reflect.DeepEqual(payload.TeamAccessPolicies, endpoint.TeamAccessPolicies) {
|
|
endpoint.TeamAccessPolicies = payload.TeamAccessPolicies
|
|
updateAuthorizations = true
|
|
}
|
|
|
|
if payload.Status != nil {
|
|
switch *payload.Status {
|
|
case 1:
|
|
endpoint.Status = portainer.EndpointStatusUp
|
|
break
|
|
case 2:
|
|
endpoint.Status = portainer.EndpointStatusDown
|
|
break
|
|
default:
|
|
break
|
|
}
|
|
}
|
|
|
|
if endpoint.Type == portainer.AzureEnvironment {
|
|
credentials := endpoint.AzureCredentials
|
|
if payload.AzureApplicationID != nil {
|
|
credentials.ApplicationID = *payload.AzureApplicationID
|
|
}
|
|
if payload.AzureTenantID != nil {
|
|
credentials.TenantID = *payload.AzureTenantID
|
|
}
|
|
if payload.AzureAuthenticationKey != nil {
|
|
credentials.AuthenticationKey = *payload.AzureAuthenticationKey
|
|
}
|
|
|
|
httpClient := client.NewHTTPClient()
|
|
_, authErr := httpClient.ExecuteAzureAuthenticationRequest(&credentials)
|
|
if authErr != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to authenticate against Azure", authErr}
|
|
}
|
|
endpoint.AzureCredentials = credentials
|
|
}
|
|
|
|
if payload.TLS != nil {
|
|
folder := strconv.Itoa(endpointID)
|
|
|
|
if *payload.TLS {
|
|
endpoint.TLSConfig.TLS = true
|
|
if payload.TLSSkipVerify != nil {
|
|
endpoint.TLSConfig.TLSSkipVerify = *payload.TLSSkipVerify
|
|
|
|
if !*payload.TLSSkipVerify {
|
|
caCertPath, _ := handler.FileService.GetPathForTLSFile(folder, portainer.TLSFileCA)
|
|
endpoint.TLSConfig.TLSCACertPath = caCertPath
|
|
} else {
|
|
endpoint.TLSConfig.TLSCACertPath = ""
|
|
handler.FileService.DeleteTLSFile(folder, portainer.TLSFileCA)
|
|
}
|
|
}
|
|
|
|
if payload.TLSSkipClientVerify != nil {
|
|
if !*payload.TLSSkipClientVerify {
|
|
certPath, _ := handler.FileService.GetPathForTLSFile(folder, portainer.TLSFileCert)
|
|
endpoint.TLSConfig.TLSCertPath = certPath
|
|
keyPath, _ := handler.FileService.GetPathForTLSFile(folder, portainer.TLSFileKey)
|
|
endpoint.TLSConfig.TLSKeyPath = keyPath
|
|
} else {
|
|
endpoint.TLSConfig.TLSCertPath = ""
|
|
handler.FileService.DeleteTLSFile(folder, portainer.TLSFileCert)
|
|
endpoint.TLSConfig.TLSKeyPath = ""
|
|
handler.FileService.DeleteTLSFile(folder, portainer.TLSFileKey)
|
|
}
|
|
}
|
|
|
|
} else {
|
|
endpoint.TLSConfig.TLS = false
|
|
endpoint.TLSConfig.TLSSkipVerify = false
|
|
endpoint.TLSConfig.TLSCACertPath = ""
|
|
endpoint.TLSConfig.TLSCertPath = ""
|
|
endpoint.TLSConfig.TLSKeyPath = ""
|
|
err = handler.FileService.DeleteTLSFiles(folder)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to remove TLS files from disk", err}
|
|
}
|
|
}
|
|
}
|
|
|
|
if payload.URL != nil || payload.TLS != nil || endpoint.Type == portainer.AzureEnvironment {
|
|
_, err = handler.ProxyManager.CreateAndRegisterEndpointProxy(endpoint)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to register HTTP proxy for the endpoint", err}
|
|
}
|
|
}
|
|
|
|
err = handler.EndpointService.UpdateEndpoint(endpoint.ID, endpoint)
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to persist endpoint changes inside the database", err}
|
|
}
|
|
|
|
if updateAuthorizations {
|
|
err = handler.AuthorizationService.UpdateUsersAuthorizations()
|
|
if err != nil {
|
|
return &httperror.HandlerError{http.StatusInternalServerError, "Unable to update user authorizations", err}
|
|
}
|
|
}
|
|
|
|
return response.JSON(w, endpoint)
|
|
}
|