mirror of
https://github.com/portainer/portainer.git
synced 2025-07-21 14:29:40 +02:00
* feat(helm): add helm chart backport to ce EE-1409 (#5425) * EE-1311 Helm Chart Backport from EE * backport to ce Co-authored-by: Matt Hook <hookenz@gmail.com> * feat(helm): list and configure helm chart (#5431) * backport and tidyup code * --amend * using rocket icon for charts * helm chart bugfix - clear category button * added matomo analytics for helm chart install * fix web editor exit warning without changes * editor modified exit bugfix * fixed notifications typo * updated helm template text * helper text to convey slow helm templates load Co-authored-by: zees-dev <dev.786zshan@gmail.com> * removing redundant time-consuming api call by using prop attribute * feat(helm) helm chart backport from ee EE-1311 (#5436) * Add missing defaultHelmRepoUrl and mock testing * Backport EE-1477 * Backport updates to helm tests from EE * add https by default changes and ssl to tls renaming from EE * Port install integration test. Disabled by default to pass CI checks * merged changes from EE for the integration test * kube proxy whitelist updated to support internal helm install command Co-authored-by: zees-dev <dev.786zshan@gmail.com> * Pull in all changes from tech review in EE-943 * added helm to sidebar after rebase, sync CE with EE * bugfix: kubectl shell not opening - bearer token bug * tidy go modules & remove yarn-error.log * removed redundant handler (not used) - to match EE * resolved merge conflicts, updated code * feat(helm/views): helm release and application views EE-1236 (#5529) * feat(helm): add helm chart backport to ce EE-1409 (#5425) * EE-1311 Helm Chart Backport from EE * backport to ce Co-authored-by: Matt Hook <hookenz@gmail.com> * Pull in all changes from tech review in EE-943 * added helm to sidebar after rebase, sync CE with EE * removed redundant handler (not used) - to match EE * feat(helm) display helm charts - backend EE-1236 * copy over components for new applications view EE-1236 * Add new applications datatable component * Add more migrated files * removed test not applicable to CE * baclkported EE app data table code to CE * removed redundant helm repo url * resolved conflicts, updated code * using endpoint middleware * PR review fixes * using constants, openapi updated Co-authored-by: Richard Wei <54336863+WaysonWei@users.noreply.github.com> Co-authored-by: zees-dev <dev.786zshan@gmail.com> * fixed test conflicts, go linted * feat(helm/templates-add): helm templates add repo for user support EE-1278 (#5514) * feat(helm): add helm chart backport to ce EE-1409 (#5425) * EE-1311 Helm Chart Backport from EE * backport to ce Co-authored-by: Matt Hook <hookenz@gmail.com> * feat(helm) helm chart backport from ee EE-1311 (#5436) * Add missing defaultHelmRepoUrl and mock testing * Backport EE-1477 * Backport updates to helm tests from EE * add https by default changes and ssl to tls renaming from EE * Port install integration test. Disabled by default to pass CI checks * merged changes from EE for the integration test * kube proxy whitelist updated to support internal helm install command Co-authored-by: zees-dev <dev.786zshan@gmail.com> * Pull in all changes from tech review in EE-943 * feat(helm): add helm chart backport to ce EE-1409 (#5425) * EE-1311 Helm Chart Backport from EE * backport to ce Co-authored-by: Matt Hook <hookenz@gmail.com> * Pull in all changes from tech review in EE-943 * added helm to sidebar after rebase, sync CE with EE * backport EE-1278, squashed, diffed, updated * helm install openapi spec update * resolved conflicts, updated code * - matching ee codebase at 0afe57034449ee0e9f333d92c252a13995a93019 - helm install using endpoint middleware - remove trailing slash from added/persisted helm repo urls * feat(helm) use libhelm url validator and improved path assembly EE-1554 (#5561) * feat(helm/userrepos) fix getting global repo for ordinary users EE-1562 (#5567) * feat(helm/userrepos) fix getting global repo for ordinary users EE-1562 * post review changes and further backported changes from EE * resolved conflicts, updated code * fixed helm_install handler unit test * user cannot add existing repo if suffix is '/' (#5571) * feat(helm/docs) fix broken swagger docs EE-1278 (#5572) * Fix swagger docs * minor correction * fix(helm): migrating code from user handler to helm handler (#5573) * - migrated user_helm_repos to helm endpoint handler - migrated api operations from user factory/service to helm factory/service - passing endpointId into helm service/factory as endpoint provider is deprecated * upgrade libhelm to hide secrets Co-authored-by: Matt Hook <hookenz@gmail.com> * removed duplicate file - due to merge conflict * dependency injection in helm factory Co-authored-by: Richard Wei <54336863+WaysonWei@users.noreply.github.com> Co-authored-by: Matt Hook <hookenz@gmail.com> * kubernetes.templates -> kubernetes.templates.helm name conflict fix * Validate the URL added as a public helm repo (#5579) * fix(helm): helm app deletion fix EE-1581 (#5582) * updated helm lib to show correct error on uninstall failure * passing down helm app namespace on deletion * fix(k8s): EE-1591 non-admin users cannot deploy charts containing secrets (#5590) Co-authored-by: Simon Meng <simon.meng@portainer.io> * fix(helm): helm epic bugfixes EE-1582 EE-1593 (#5585) * - trim trailing slash and lowercase before persisting helm repo - browser helm templates url /kubernetes/templates/templates -> /kubernetes/templates/helm - fix publish url - fix helm repo add refresh - semi-fix k8s app expansion * Tidy up swagger documentation related to helm. Make json consistent * fixed helm release page for non-default namespaces * k8s app view table expansion bugfix * EE-1593: publish url load balancer fallback Co-authored-by: Matt Hook <hookenz@gmail.com> * k8s app list fix for charts with deployments containing multiple pods - which use the same label (#5599) * fix(kubernetes): app list view fix for secrets with long keys or values EE-1600 (#5600) * k8s app secrets key value text overflow ellipses * wrapping key value pairs instead of ellipses * fix(helm): helm apps bundling issue across different namespaces EE-1619 (#5602) * helm apps bundling issue across different namespaces * - code comments and indentation to ease reading - moved namespace calc out of loop * feat(helm/test) disable slow helm search test by default EE-1599 (#5598) * skip helm_repo_search as it's an integration test * switch to portainer built in integration test checker * make module order match EE * don't print test struct out when skipping integration test Co-authored-by: Richard Wei <54336863+WaysonWei@users.noreply.github.com> Co-authored-by: Matt Hook <hookenz@gmail.com> Co-authored-by: cong meng <mcpacino@gmail.com> Co-authored-by: Simon Meng <simon.meng@portainer.io>
301 lines
10 KiB
Go
301 lines
10 KiB
Go
package security
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"strings"
|
|
|
|
httperror "github.com/portainer/libhttp/error"
|
|
portainer "github.com/portainer/portainer/api"
|
|
bolterrors "github.com/portainer/portainer/api/bolt/errors"
|
|
httperrors "github.com/portainer/portainer/api/http/errors"
|
|
)
|
|
|
|
type (
|
|
// RequestBouncer represents an entity that manages API request accesses
|
|
RequestBouncer struct {
|
|
dataStore portainer.DataStore
|
|
jwtService portainer.JWTService
|
|
}
|
|
|
|
// RestrictedRequestContext is a data structure containing information
|
|
// used in AuthenticatedAccess
|
|
RestrictedRequestContext struct {
|
|
IsAdmin bool
|
|
IsTeamLeader bool
|
|
UserID portainer.UserID
|
|
UserMemberships []portainer.TeamMembership
|
|
}
|
|
)
|
|
|
|
// NewRequestBouncer initializes a new RequestBouncer
|
|
func NewRequestBouncer(dataStore portainer.DataStore, jwtService portainer.JWTService) *RequestBouncer {
|
|
return &RequestBouncer{
|
|
dataStore: dataStore,
|
|
jwtService: jwtService,
|
|
}
|
|
}
|
|
|
|
// PublicAccess defines a security check for public API endpoints.
|
|
// No authentication is required to access these endpoints.
|
|
func (bouncer *RequestBouncer) PublicAccess(h http.Handler) http.Handler {
|
|
h = mwSecureHeaders(h)
|
|
return h
|
|
}
|
|
|
|
// AdminAccess defines a security check for API endpoints that require an authorization check.
|
|
// Authentication is required to access these endpoints.
|
|
// The administrator role is required to use these endpoints.
|
|
// The request context will be enhanced with a RestrictedRequestContext object
|
|
// that might be used later to inside the API operation for extra authorization validation
|
|
// and resource filtering.
|
|
func (bouncer *RequestBouncer) AdminAccess(h http.Handler) http.Handler {
|
|
h = bouncer.mwUpgradeToRestrictedRequest(h)
|
|
h = bouncer.mwCheckPortainerAuthorizations(h, true)
|
|
h = bouncer.mwAuthenticatedUser(h)
|
|
return h
|
|
}
|
|
|
|
// RestrictedAccess defines a security check for restricted API endpoints.
|
|
// Authentication is required to access these endpoints.
|
|
// The request context will be enhanced with a RestrictedRequestContext object
|
|
// that might be used later to inside the API operation for extra authorization validation
|
|
// and resource filtering.
|
|
func (bouncer *RequestBouncer) RestrictedAccess(h http.Handler) http.Handler {
|
|
h = bouncer.mwUpgradeToRestrictedRequest(h)
|
|
h = bouncer.mwCheckPortainerAuthorizations(h, false)
|
|
h = bouncer.mwAuthenticatedUser(h)
|
|
return h
|
|
}
|
|
|
|
// AuthenticatedAccess defines a security check for restricted API endpoints.
|
|
// Authentication is required to access these endpoints.
|
|
// The request context will be enhanced with a RestrictedRequestContext object
|
|
// that might be used later to inside the API operation for extra authorization validation
|
|
// and resource filtering.
|
|
func (bouncer *RequestBouncer) AuthenticatedAccess(h http.Handler) http.Handler {
|
|
h = bouncer.mwUpgradeToRestrictedRequest(h)
|
|
h = bouncer.mwAuthenticatedUser(h)
|
|
return h
|
|
}
|
|
|
|
// AuthorizedEndpointOperation retrieves the JWT token from the request context and verifies
|
|
// that the user can access the specified endpoint.
|
|
// An error is returned when access to the endpoint is denied or if the user do not have the required
|
|
// authorization to execute the operation.
|
|
func (bouncer *RequestBouncer) AuthorizedEndpointOperation(r *http.Request, endpoint *portainer.Endpoint) error {
|
|
tokenData, err := RetrieveTokenData(r)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if tokenData.Role == portainer.AdministratorRole {
|
|
return nil
|
|
}
|
|
|
|
memberships, err := bouncer.dataStore.TeamMembership().TeamMembershipsByUserID(tokenData.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
group, err := bouncer.dataStore.EndpointGroup().EndpointGroup(endpoint.GroupID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if !authorizedEndpointAccess(endpoint, group, tokenData.ID, memberships) {
|
|
return httperrors.ErrEndpointAccessDenied
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// AuthorizedEdgeEndpointOperation verifies that the request was received from a valid Edge endpoint
|
|
func (bouncer *RequestBouncer) AuthorizedEdgeEndpointOperation(r *http.Request, endpoint *portainer.Endpoint) error {
|
|
if endpoint.Type != portainer.EdgeAgentOnKubernetesEnvironment && endpoint.Type != portainer.EdgeAgentOnDockerEnvironment {
|
|
return errors.New("Invalid environment type")
|
|
}
|
|
|
|
edgeIdentifier := r.Header.Get(portainer.PortainerAgentEdgeIDHeader)
|
|
if edgeIdentifier == "" {
|
|
return errors.New("missing Edge identifier")
|
|
}
|
|
|
|
if endpoint.EdgeID != "" && endpoint.EdgeID != edgeIdentifier {
|
|
return errors.New("invalid Edge identifier")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// handlers are applied backwards to the incoming request:
|
|
// - add secure handlers to the response
|
|
// - parse the JWT token and put it into the http context.
|
|
func (bouncer *RequestBouncer) mwAuthenticatedUser(h http.Handler) http.Handler {
|
|
h = bouncer.mwCheckAuthentication(h)
|
|
h = mwSecureHeaders(h)
|
|
return h
|
|
}
|
|
|
|
// mwCheckPortainerAuthorizations will verify that the user has the required authorization to access
|
|
// a specific API endpoint.
|
|
// If the administratorOnly flag is specified, this will prevent non-admin
|
|
// users from accessing the endpoint.
|
|
func (bouncer *RequestBouncer) mwCheckPortainerAuthorizations(next http.Handler, administratorOnly bool) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
tokenData, err := RetrieveTokenData(r)
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusForbidden, "Access denied", httperrors.ErrUnauthorized)
|
|
return
|
|
}
|
|
|
|
if tokenData.Role == portainer.AdministratorRole {
|
|
next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
if administratorOnly {
|
|
httperror.WriteError(w, http.StatusForbidden, "Access denied", httperrors.ErrUnauthorized)
|
|
return
|
|
}
|
|
|
|
_, err = bouncer.dataStore.User().User(tokenData.ID)
|
|
if err != nil && err == bolterrors.ErrObjectNotFound {
|
|
httperror.WriteError(w, http.StatusUnauthorized, "Unauthorized", httperrors.ErrUnauthorized)
|
|
return
|
|
} else if err != nil {
|
|
httperror.WriteError(w, http.StatusInternalServerError, "Unable to retrieve user details from the database", err)
|
|
return
|
|
}
|
|
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
// mwUpgradeToRestrictedRequest will enhance the current request with
|
|
// a new RestrictedRequestContext object.
|
|
func (bouncer *RequestBouncer) mwUpgradeToRestrictedRequest(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
tokenData, err := RetrieveTokenData(r)
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusForbidden, "Access denied", httperrors.ErrResourceAccessDenied)
|
|
return
|
|
}
|
|
|
|
requestContext, err := bouncer.newRestrictedContextRequest(tokenData.ID, tokenData.Role)
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusInternalServerError, "Unable to create restricted request context ", err)
|
|
return
|
|
}
|
|
|
|
ctx := StoreRestrictedRequestContext(r, requestContext)
|
|
next.ServeHTTP(w, r.WithContext(ctx))
|
|
})
|
|
}
|
|
|
|
// mwCheckAuthentication provides Authentication middleware for handlers
|
|
//
|
|
// It parses the JWT token and adds the parsed token data to the http context
|
|
func (bouncer *RequestBouncer) mwCheckAuthentication(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
var tokenData *portainer.TokenData
|
|
|
|
// get token from the Authorization header or query parameter
|
|
token, err := ExtractBearerToken(r)
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusUnauthorized, "Unauthorized", err)
|
|
return
|
|
}
|
|
|
|
tokenData, err = bouncer.jwtService.ParseAndVerifyToken(token)
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusUnauthorized, "Invalid JWT token", err)
|
|
return
|
|
}
|
|
|
|
_, err = bouncer.dataStore.User().User(tokenData.ID)
|
|
if err != nil && err == bolterrors.ErrObjectNotFound {
|
|
httperror.WriteError(w, http.StatusUnauthorized, "Unauthorized", httperrors.ErrUnauthorized)
|
|
return
|
|
} else if err != nil {
|
|
httperror.WriteError(w, http.StatusInternalServerError, "Unable to retrieve user details from the database", err)
|
|
return
|
|
}
|
|
|
|
ctx := StoreTokenData(r, tokenData)
|
|
next.ServeHTTP(w, r.WithContext(ctx))
|
|
})
|
|
}
|
|
|
|
// ExtractBearerToken extracts the Bearer token from the request header or query parameter and returns the token.
|
|
func ExtractBearerToken(r *http.Request) (string, error) {
|
|
// Optionally, token might be set via the "token" query parameter.
|
|
// For example, in websocket requests
|
|
token := r.URL.Query().Get("token")
|
|
|
|
tokens, ok := r.Header["Authorization"]
|
|
if ok && len(tokens) >= 1 {
|
|
token = tokens[0]
|
|
token = strings.TrimPrefix(token, "Bearer ")
|
|
}
|
|
if token == "" {
|
|
return "", httperrors.ErrUnauthorized
|
|
}
|
|
return token, nil
|
|
}
|
|
|
|
// mwSecureHeaders provides secure headers middleware for handlers.
|
|
func mwSecureHeaders(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Add("X-XSS-Protection", "1; mode=block")
|
|
w.Header().Add("X-Content-Type-Options", "nosniff")
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|
|
|
|
func (bouncer *RequestBouncer) newRestrictedContextRequest(userID portainer.UserID, userRole portainer.UserRole) (*RestrictedRequestContext, error) {
|
|
if userRole == portainer.AdministratorRole {
|
|
return &RestrictedRequestContext{
|
|
IsAdmin: true,
|
|
UserID: userID,
|
|
}, nil
|
|
}
|
|
|
|
memberships, err := bouncer.dataStore.TeamMembership().TeamMembershipsByUserID(userID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
isTeamLeader := false
|
|
for _, membership := range memberships {
|
|
if membership.Role == portainer.TeamLeader {
|
|
isTeamLeader = true
|
|
}
|
|
}
|
|
|
|
return &RestrictedRequestContext{
|
|
IsAdmin: false,
|
|
UserID: userID,
|
|
IsTeamLeader: isTeamLeader,
|
|
UserMemberships: memberships,
|
|
}, nil
|
|
}
|
|
|
|
// EdgeComputeOperation defines a restriced edge compute operation.
|
|
// Use of this operation will only be authorized if edgeCompute is enabled in settings
|
|
func (bouncer *RequestBouncer) EdgeComputeOperation(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
settings, err := bouncer.dataStore.Settings().Settings()
|
|
if err != nil {
|
|
httperror.WriteError(w, http.StatusServiceUnavailable, "Unable to retrieve settings", err)
|
|
return
|
|
}
|
|
|
|
if !settings.EnableEdgeComputeFeatures {
|
|
httperror.WriteError(w, http.StatusServiceUnavailable, "Edge compute features are disabled", errors.New("Edge compute features are disabled"))
|
|
return
|
|
}
|
|
|
|
next.ServeHTTP(w, r)
|
|
})
|
|
}
|