Docker/portainer
Docker/portainer
1
0
Fork 0
mirror of https://github.com/portainer/portainer.git synced 2025-07-24 07:49:41 +02:00
Code Issues Releases Activity

fix messaging for resourse over commit (#10974)

Browse source
This commit is contained in:
Prabhat Khera 2024-01-19 12:14:47 +13:00 • committed by GitHub
parent 59f642ea56
commit a4739f1701
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

29
app/react/kubernetes/cluster/ConfigureView/ConfigureForm/ConfigureForm.tsx
View file

@ -19,6 +19,7 @@ import { FormActions } from '@@/form-components/FormActions';
import { confirm } from '@@/modals/confirm'; import { confirm } from '@@/modals/confirm';
import { ModalType } from '@@/modals'; import { ModalType } from '@@/modals';
import { buildConfirmButton } from '@@/modals/utils'; import { buildConfirmButton } from '@@/modals/utils';
import { InsightsBox } from '@@/InsightsBox';
import { useIngressControllerClassMapQuery } from '../../ingressClass/useIngressControllerClassMap'; import { useIngressControllerClassMapQuery } from '../../ingressClass/useIngressControllerClassMap';
import { IngressControllerClassMap } from '../../ingressClass/types'; import { IngressControllerClassMap } from '../../ingressClass/types';
@ -284,29 +285,35 @@ function InnerForm({
</div> </div>
</FormSection> </FormSection>
<FormSection title="Resources and Metrics"> <FormSection title="Resources and Metrics">
<TextTip color="orange"> <InsightsBox
<p> insightCloseId="resourceOverCommit"
By ENABLING resource over-commit, you are able to assign more className="mb-4"
resources to namespaces than is physically available in the header="Allow resource over-commit - UI-only change in 2.20"
cluster. This may lead to unexpected deployment failures if there content="Resource over-commit has always been ENABLED in Portainer CE. However, the toggle was incorrectly shown as OFF. This has now been corrected but please note that no functionality has been removed."
is insufficient resource to service demand. />
</p>
</TextTip>
<TextTip color="blue"> <TextTip color="blue">
<p> <p>
By DISABLING resource over-commit (highly recommended), you are By DISABLING resource over-commit (highly recommended), you can
only able to assign resources to namespaces that are less (in ONLY assign namespaces CPU and memory resources that are less (in
aggregate) than the cluster total minus any system resource aggregate) than the cluster total minus any system resource
reservation. reservation.
</p> </p>
</TextTip> </TextTip>
<TextTip color="orange">
<p>
By ENABLING resource over-commit, you can assign namespaces more
resources than are physically available in the cluster. This may
lead to unexpected deployment failures if there are insufficient
resources to service demand.
</p>
</TextTip>
<div className="form-group"> <div className="form-group">
<div className="col-sm-12"> <div className="col-sm-12">
<SwitchField <SwitchField
label="Allow resource over-commit" label="Allow resource over-commit"
labelClass="col-sm-5 col-lg-4" labelClass="col-sm-5 col-lg-4"
name="resourceOverCommitPercentage" name="resourceOverCommitPercentage"
checked={values.enableResourceOverCommit} checked
featureId={FeatureId.K8S_SETUP_DEFAULT} featureId={FeatureId.K8S_SETUP_DEFAULT}
onChange={(checked: boolean) => { onChange={(checked: boolean) => {
setFieldValue('enableResourceOverCommit', checked); setFieldValue('enableResourceOverCommit', checked);